Updated developer documenation #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
added
Documentation
|
Hello @nabobalis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-03-20 21:03:11 UTC |
|
Thanks for the pull request @nabobalis! Everything looks great! |
nabobalis
commented
Mar 3, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Cadair
reviewed
Mar 13, 2019
hayesla
reviewed
Mar 13, 2019
wafels
reviewed
Mar 13, 2019
Cadair
approved these changes
Mar 16, 2019
Cadair
reviewed
Mar 16, 2019
Cadair
approved these changes
Mar 20, 2019
* Added another section to the newcomers guide on checking your code.
* Addressed comments about confusing sections.
* Fixed some typos.
|
I'm gonna merge this in now and if any problems arise, we can fix them after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part 1 of the epic journey that is, "Nabil goes over all the files in SunPy".
Merged in #2934
Fixes #2931
Fixes #2925
Fixes #1858
Fixes #856
Fixes #1618
Fixes #212
CONTRIBUTING.rst is the one to check the most
The other changes are mainly within the
dev_guidesection that hopefully explain more about our test suite and how to write/run aspects of SunPyBuilt docs.